test: replace mock axis tests with component-level fill/class tests#517
Merged
test: replace mock axis tests with component-level fill/class tests#517
Conversation
Pin color.domain and fx.domain in faceted bars example so unchecking a party checkbox no longer reshuffles remaining bars' colors. Allow null values in fx/fy scale domains (#99) — null is a valid grouping category for facet scales. Also exempt fx/fy from the data validity check in Mark.svelte so null-faceted records render. Fix HTMLTooltip event listener mismatch: removeEventListener was using 'mouseleave' instead of 'pointerleave', causing a leak. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use a scheme dictionary mapping party names to recognizable colors instead of relying on domain + default categorical colors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…chemes The runtime already supports dictionary objects as color schemes (autoScales.ts:246) but the type definition didn't include them. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace axis-properties-fix.test.ts (mock-only tests) with real component-level tests in axisY.test.ts that verify AxisY fill prop works with both constant values and function accessors. Closes #142 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Deploy Preview for svelteplot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
axis-properties-fix.test.ts(mock-only interface tests) with real component-level tests inaxisY.test.tsAxisYfillprop with constant value ('red')AxisYfillprop with function accessor ((d, i) => ...)All 3 bugs from #142 are now accounted for:
axisY.test.tstests verify class application)Closes #142
Test plan
pnpm test -- src/tests/axisY.test.ts— all 19 tests pass🤖 Generated with Claude Code