fix: add support for dx/dy transform to Grid marks#175
Merged
Conversation
✅ Deploy Preview for svelteplot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-175
# or install the specific version
npm install svelteplot@0.3.11-pr-175.0 |
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-175
# or install the specific version
npm install svelteplot@0.3.11-pr-175.1 |
2 tasks
gka
added a commit
that referenced
this pull request
Mar 9, 2026
…517) ## Summary - Replace `axis-properties-fix.test.ts` (mock-only interface tests) with real component-level tests in `axisY.test.ts` - Add test for `AxisY` `fill` prop with constant value (`'red'`) - Add test for `AxisY` `fill` prop with function accessor (`(d, i) => ...`) All 3 bugs from #142 are now accounted for: 1. **GridY.dx** — fixed in #175 (merged) 2. **AxisY.fill** — confirmed working via new component tests 3. **AxisY.class** — confirmed working (existing `axisY.test.ts` tests verify class application) Closes #142 ## Test plan - [x] `pnpm test -- src/tests/axisY.test.ts` — all 19 tests pass - [x] Pre-commit hooks (prettier, oxlint) pass 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Gregor Aisch <gka@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #142
This pull request adds support for
dxanddyoffset properties to theGridXandGridYSvelte mark components, allowing for more flexible grid positioning. It also introduces new test suites for these components to verify correct handling of style and transform properties, and removes outdated test files.Enhancements to Grid Marks:
dxanddyproperties in bothGridXandGridYcomponents, enabling per-line translation offsets via the newresolveProphelper. These offsets are now applied in the SVGtransformattribute for each grid line.Testing improvements:
gridX.test.svelte.tsandgridY.test.svelte.tsto verify grid mark rendering, style application, and dynamic updates todxanddyproperties, including function-valued offsets.