types: Fix svelte-check issues in mark helpers#482
Merged
Conversation
Resolves #467 Summary - align `RegressionX/Y` props with the updated helper interface so they import `RegressionOptions` now that the helper exports the shared props - expand `helpers/Regression.svelte` to normalize regression inputs, handle optional parameters, and tighten confidence-band logic with better numeric conversions and comments - cast regression example state types and silence ts-lint noise in the regression tests so `pnpm lint:types` no longer errors - passes canvas prop to Area + Line marks Testing - Not run (not requested)
✅ Deploy Preview for svelteplot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-482
# or install the specific version
npm install svelteplot@0.10.3-pr-482.0 |
gka
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #467
Resolves #457
Resolves #458
Resolves #459
Resolves #460
Resolves #464
Resolves #465
Resolves #469
This pull request focuses on improving type safety and robustness across several mark helper components, especially for canvas rendering and box plot handling. The changes mainly address stricter typing, better handling of optional and default values, and more reliable property resolution. These updates help prevent runtime errors and make the codebase easier to maintain.
Type Safety and Robustness Improvements
RegressionX.svelteandRegressionY.svelteto useRegressionOptions, adding a newcanvasproperty for flexibility in rendering. [1] [2]Box.svelteby enforcing array types fordata, adding explicit type casts in data processing, and improving sorting and channel resolution logic for box plot calculations. [1] [2] [3] [4] [5] [6] [7] [8]DotCanvas.svelte,GeoCanvas.svelte,LineCanvas.svelte) to ensure correct property resolution, safer color and opacity handling, and more robust rendering logic. [1] [2] [3] [4] [5] [6] [7] [8] [9]Marker and Multiline Text Improvements
MarkerPath.svelteby adding support for reversed paths, handling optional and default values for marker properties, and ensuring correct rendering of markers and invisible paths for mouse access. [1] [2] [3] [4] [5]MultilineText.sveltefor more reliable text alignment and style handling. [1] [2]