Merged
Conversation
✅ Deploy Preview for svelteplot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-480
# or install the specific version
npm install svelteplot@0.10.3-pr-480.0 |
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-480
# or install the specific version
npm install svelteplot@0.10.3-pr-480.1 |
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-480
# or install the specific version
npm install svelteplot@0.10.3-pr-480.2 |
gka
added a commit
that referenced
this pull request
Feb 22, 2026
Resolves #467 Summary - align `RegressionX/Y` props with the updated helper interface so they import `RegressionOptions` now that the helper exports the shared props - expand `helpers/Regression.svelte` to normalize regression inputs, handle optional parameters, and tighten confidence-band logic with better numeric conversions and comments - cast regression example state types and silence ts-lint noise in the regression tests so `pnpm lint:types` no longer errors - passes canvas prop to Area + Line marks Testing - Not run (not requested)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #467
Summary
RegressionX/Yprops with the updated helper interface so they importRegressionOptionsnow that the helper exports the shared propshelpers/Regression.svelteto normalize regression inputs, handle optional parameters, and tighten confidence-band logic with better numeric conversions and commentspnpm lint:typesno longer errorsTesting