Tip modifier#37
Conversation
|
Actually it doesn't work when the author of the commit is not based on the latest commit. It may happen for example if there's any commit pushed between the pull request creation and the merge. I thought it would not happen, but in fact it will be quite frequent. |
There was a problem hiding this comment.
I think we don't need this line now! what say?
There was a problem hiding this comment.
I think we do. Without this change, if there are 101 commits coming in the same update, 101% of the balance will be given in tips. That won't work.
It's something we should probably fix outside this pull request because it won't be merged.
There was a problem hiding this comment.
Oh sorry, you meant the project: line. Indeed, we don't need it.
There was a problem hiding this comment.
Hey I think there are some issues in this PR as you already illustrated in the scenarios. So are you going to merge and deploy this?
There was a problem hiding this comment.
No. It won't work. I'm going to try another approach: #44
2 participants
Same as #34 with a few fixes.