Environment Variables can now be set for Parsers#532
Merged
Conversation
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
JohannesZahn
force-pushed
the
feature/add-env-variables-to-parsedefinitions
branch
from
111c63e to
56f2e66
Compare
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
JohannesZahn
force-pushed
the
feature/add-env-variables-to-parsedefinitions
branch
from
56f2e66 to
b639c47
Compare
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
Contributor
Author
|
As @J12934 suggested we should discuss in the review if we want to handle feature flags for parsers like this before merging. |
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
JohannesZahn
force-pushed
the
feature/add-env-variables-to-parsedefinitions
branch
from
51aa75e to
de223e7
Compare
JohannesZahn
changed the title
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
J12934
approved these changes
Jul 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added empty environment variable array to the parse definitions. Also removed the ncrack secrect in the parse definition as it is not required anymore according to @J12934.
This will be used for #520, so users can decide if they want the program to crash if the Findings validation detects invalid findings. This also enables integration tests for the Findings Validation. A environment variable can simply be set to true to make the tests fail if the validation fails.
Checklist
npm testruns for the whole project.