Skip to content

Validate SCB Findings in Unit Tests#520

Merged
JohannesZahn merged 36 commits intomainfrom
feature/findings-validation
Jul 20, 2021
Merged

Validate SCB Findings in Unit Tests#520
JohannesZahn merged 36 commits intomainfrom
feature/findings-validation

Conversation

@JohannesZahn
Copy link
Contributor

@JohannesZahn JohannesZahn commented Jun 24, 2021 •
edited
Loading

Description

Validate Findings in Unit Tests. This is not meant to introduce a reasonable findings schema, it simply implements the code to be able to validate the findings. Currently the findings schema is purposly forgiving so all parser pass the test as they are.

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure npm test runs for the whole project.
  • Make codeclimate checks happy
  • Introduce findings-schema
  • Validate all Parsers in unit tests
  • Add new field ip_tcp_stack_layer that should replace osi_layer in the future

@JohannesZahn
added basic findings schema
b6a3bd6 
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
@JohannesZahn
local findings validation with basic schema
fe448f7 
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
@JohannesZahn
move verification to parserSDK
9be8ceb 
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
@JohannesZahn
Merge branch 'main' into feature/findings-validation
f1c0c74 
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
@JohannesZahn
add descriptions for findis schema
b4457ad 
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
@JohannesZahn
add method to validate in unit tests
c050cfe 
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
nigthknight
nigthknight reviewed Jun 29, 2021
View reviewed changes
@JohannesZahn @nigthknight
Update parser-sdk/nodejs/parser-utils.js
d5c2b6c 
Co-authored-by: Yannik Fuhrmeister <12710254+fuhrmeistery@users.noreply.github.com>
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
@JohannesZahn JohannesZahn force-pushed the feature/findings-validation branch from 44a6aa2 to d5c2b6c Compare June 29, 2021 13:27
@JohannesZahn
improve import of parser sdk
58c4840 
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
@JohannesZahn
add nikto validation
26562b0 
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
J12934
J12934 reviewed Jul 1, 2021
View reviewed changes
@JohannesZahn
add stricter formats and better errors
989f8b2 
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
@JohannesZahn JohannesZahn mentioned this pull request Jul 1, 2021
Merged
4 tasks
@JohannesZahn
improve schema descriptions and add new attributes
bb9f67b 
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
@JohannesZahn
add validation to unit tests
0d90fb8 
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
@JohannesZahn
fix bug where variable was not initialized
9d786b8 
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
@JohannesZahn
fix typo
4f0ab79 
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
@JohannesZahn
fix bug where empty findings files would be not be parsed correctly
daf88de 
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
@JohannesZahn
adjust findings schema to make all unit tests pass (for now)
5be559e 
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
@JohannesZahn
Merge branch 'main' into feature/findings-validation
0b1a32a
@JohannesZahn
sync package-lock
deb4bf7 
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
@JohannesZahn JohannesZahn changed the title Validate Findings Validate Findings in Unit Tests Jul 6, 2021
@JohannesZahn JohannesZahn force-pushed the feature/findings-validation branch from 5fec3fc to deb4bf7 Compare July 6, 2021 12:39
@JohannesZahn
update package-lock
853ed7d 
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
@JohannesZahn
sync package-lock for hooks
038676f 
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
@JohannesZahn
update package-lock
ac21a7d 
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
@JohannesZahn
make codeclimate happy
b3e4c12 
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
@JohannesZahn
Merge branch 'main' into feature/findings-validation
b15fdc5
@JohannesZahn
copy parser utils to docker image
cafca44 
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
@JohannesZahn JohannesZahn added this to the v3.0.0 milestone Jul 13, 2021
@JohannesZahn JohannesZahn marked this pull request as draft July 13, 2021 12:36
@JohannesZahn
add tcp-ip layer to findings-schema
bdf2e61 
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
@JohannesZahn JohannesZahn marked this pull request as ready for review July 14, 2021 06:10
@JohannesZahn JohannesZahn mentioned this pull request Jul 16, 2021
Closed
15 tasks
@JohannesZahn JohannesZahn force-pushed the feature/findings-validation branch 2 times, most recently from dcf29e4 to bdf2e61 Compare July 20, 2021 07:19
@JohannesZahn
Merge remote-tracking branch 'origin/main' into feature/findings-vali…
9d521cb 
…dation

Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
@JohannesZahn JohannesZahn force-pushed the feature/findings-validation branch from 67bec78 to 9d521cb Compare July 20, 2021 09:43
@JohannesZahn
update package-lock
26e09c8 
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
@JohannesZahn
remove osi and tcp_ip layer from findings format
a54b9f0 
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
J12934
J12934 requested changes Jul 20, 2021
View reviewed changes
@JohannesZahn JohannesZahn linked an issue Jul 20, 2021 that may be closed by this pull request
Change "OSI Layer" to TCP/IP Layer #543
Closed
JohannesZahn and others added 4 commits July 20, 2021 13:06
@JohannesZahn @J12934
Update parser-sdk/nodejs/parser-utils.js
08554d8 
Change import from var to const

Co-authored-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
@JohannesZahn @J12934
Update parser-sdk/nodejs/parser-utils.js
e177fa1 
replace for loop by functional style code

Co-authored-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
@JohannesZahn
remove unused eslint disabling
5cfee4c 
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
@JohannesZahn
remove unnecessary empty array check
e2a3ef8 
Signed-off-by: Johannes Zahn <johannes.zahn@iteratec.com>
@JohannesZahn JohannesZahn enabled auto-merge July 20, 2021 14:07
@JohannesZahn JohannesZahn disabled auto-merge July 20, 2021 14:28
@JohannesZahn
Updating Helm Docs
82902cf 
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
@JohannesZahn JohannesZahn force-pushed the feature/findings-validation branch from 8b88cd7 to 82902cf Compare July 20, 2021 14:35
@JohannesZahn JohannesZahn merged commit d0a3c43 into main Jul 20, 2021
@JohannesZahn JohannesZahn deleted the feature/findings-validation branch July 20, 2021 15:00
@rfelber rfelber changed the title Validate Findings in Unit Tests Validate SCB Findings in Unit Tests Aug 8, 2021
@rfelber rfelber added testing Improvements or additions regarding the test setup and removed enhancement New feature or request labels Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@J12934 J12934 J12934 approved these changes

@nigthknight nigthknight Awaiting requested review from nigthknight

Assignees

@JohannesZahn JohannesZahn

Labels

persistence Implement or update a persistence store testing Improvements or additions regarding the test setup

Projects

None yet

Milestone

v3.0.0

Development

Successfully merging this pull request may close these issues.

Change "OSI Layer" to TCP/IP Layer

4 participants

@JohannesZahn @nigthknight @J12934 @rfelber