Skip to content

Update the setup and PR lifecycle pages #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ezio-melotti merged 11 commits into from
Sep 28, 2017
Merged

Update the setup and PR lifecycle pages #265

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5038a8f
Update the setup page and the quick guides.
ezio-melotti Sep 6, 2017
25d8600
Working and markup tweaks.
ezio-melotti Sep 7, 2017
22a51dc
Remove the "Tool Setup" section.
ezio-melotti Sep 7, 2017
399b4b2
Rename the "Creating" section to "Introduction".
ezio-melotti Sep 7, 2017
3ff87b2
Reorganize info about patchcheck.
ezio-melotti Sep 7, 2017
345319a
Rename and move the "Preparation" section to "Making good PRs".
ezio-melotti Sep 7, 2017
010e9ac
Fix headers levels (by rotating quotes).
ezio-melotti Sep 7, 2017
0605bc2
Remove outdated comment.
ezio-melotti Sep 7, 2017
4ca6432
Move and refactor the sections about commits.
ezio-melotti Sep 7, 2017
f008f8d
Fix markup and long lines.
ezio-melotti Sep 7, 2017
e343c17
Convert the step-by-step guide to a bullet list.
ezio-melotti Sep 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename the "Creating" section to "Introduction".
  • Loading branch information
@ezio-melotti
ezio-melotti committed Sep 7, 2017
commit 399b4b2ed48ba178223c1a3c5897d9ac6617d099
13 changes: 4 additions & 9 deletions pullrequest.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,13 @@ Lifecycle of a Pull Request
===========================


Creating
--------
Introduction
------------

CPython uses a workflow based on pull requests. What this means is
that you create a branch in Git, make your changes, push those changes
to GitHub, and then create a pull request.
`GitHub's help pages <https://help.github.com/>`_ are good and there
are tons of pages out there for help with Git. As such, this
document does not go into any great detail as the assumption is there
is a resource out there which will explain things in a way that makes
sense for you personally when it comes to general Git and GitHub
details.
to your fork on GitHub (``origin``), and then create a pull request against
the official CPython repository (``upstream``).


Preparation
Expand Down