Skip to content

Update the setup and PR lifecycle pages #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ezio-melotti merged 11 commits into from
Sep 28, 2017
Merged

Update the setup and PR lifecycle pages #265

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5038a8f
Update the setup page and the quick guides.
ezio-melotti Sep 6, 2017
25d8600
Working and markup tweaks.
ezio-melotti Sep 7, 2017
22a51dc
Remove the "Tool Setup" section.
ezio-melotti Sep 7, 2017
399b4b2
Rename the "Creating" section to "Introduction".
ezio-melotti Sep 7, 2017
3ff87b2
Reorganize info about patchcheck.
ezio-melotti Sep 7, 2017
345319a
Rename and move the "Preparation" section to "Making good PRs".
ezio-melotti Sep 7, 2017
010e9ac
Fix headers levels (by rotating quotes).
ezio-melotti Sep 7, 2017
0605bc2
Remove outdated comment.
ezio-melotti Sep 7, 2017
4ca6432
Move and refactor the sections about commits.
ezio-melotti Sep 7, 2017
f008f8d
Fix markup and long lines.
ezio-melotti Sep 7, 2017
e343c17
Convert the step-by-step guide to a bullet list.
ezio-melotti Sep 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix headers levels (by rotating quotes).
  • Loading branch information
@ezio-melotti
ezio-melotti committed Sep 7, 2017
commit 010e9ac16da4b6e939b18fb67a8b2197af6f11d5
10 changes: 6 additions & 4 deletions pullrequest.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ the official CPython repository (``upstream``).
.. _pullrequest-quickguide:

Quick Guide
'''''''''''
-----------

.. XXX fix headers

`Clear communication`_ is key to contributing to any project, especially an
`Open Source`_ project like CPython.
Expand Down Expand Up @@ -57,7 +59,7 @@ Here is a quick overview of how you can contribute to CPython:
.. _pullrequest-steps:

Step-by-step Guide
''''''''''''''''''
------------------

You should have already :ref:`set up your system <setup>`,
:ref:`got the source code <checkout>`, and :ref:`built Python <compiling>`.
Expand Down Expand Up @@ -119,7 +121,7 @@ After your PR has been accepted and merged, you can :ref:`delete the branch <del
.. _good-prs:

Making good PRs
'''''''''''''''
---------------

When creating a pull request for submission, there are several things that you
should do to help ensure that your pull request is accepted.
Expand Down Expand Up @@ -158,7 +160,7 @@ additions/changes should be included.
.. _patchcheck:

``patchcheck``
''''''''''''''
--------------

``patchcheck`` is a simple automated patch checklist that guides a developer
through the common patch generation checks. To run ``patchcheck``:
Expand Down