Fixup decode(..., type=Struct) optimization - #88
Merged
Merged
Conversation
Between the original PR being made and merged a change went in that broke the optimization (specifically, the type code for struct types was split into `MS_TYPE_STRUCT` and `MS_TYPE_STRUCT_ARRAY`). This fixes the bug, and expands the tests to provide a more localized check for this behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Between the original PR (#77) being made and merged a change went in that
broke the optimization (specifically, the type code for struct types was
split into
MS_TYPE_STRUCTandMS_TYPE_STRUCT_ARRAY). This fixes thebug, and expands the tests to provide a more localized check for this
behavior.