Micro-optimize decode(type=Struct) - #77
Merged
Merged
Conversation
For the common case of `msgspec.json.decode(msg, type=Struct)`, we can allocate the `TypeNode` on the stack and have a faster init path, reducing overhead per call. This still isn't as fast as creating a `Decoder` once and using `Decoder.decode`, but it brings things closer. On my machine, decoding a simple `Point(x=1, y=2)` struct takes the following times: - `decode` (master): 240 ns - `decode` (this PR): 150 ns - `Decoder.decode`: 120 ns
Member
Author
|
Going to sit on this one for a bit, I'm still not sure I want the (mild) added complexity in favor of the (mild) performance improvement. |
Member
Author
|
Upon further thought, I do think this is worth it. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the common case of
msgspec.json.decode(msg, type=Struct), we canallocate the
TypeNodeon the stack and have a faster init path,reducing overhead per call. This still isn't as fast as creating a
Decoderonce and usingDecoder.decode, but it brings things closer.On my machine, decoding a simple
Point(x=1, y=2)struct takes thefollowing times:
decode(master): 240 nsdecode(this PR): 150 nsDecoder.decode: 120 ns