This repository was archived by the owner on Mar 2, 2026. It is now read-only.
chore: s.remove_staging_dirs() should only be called once#362
Merged
gcf-merge-on-green[bot] merged 1 commit intoMay 25, 2021
Conversation
google-cla
Bot
added
the
cla: yes
product-auto-label
Bot
added
the
api: firestore
tseaver
approved these changes
May 25, 2021
tseaver
added
the
automerge
gcf-merge-on-green
Bot
removed
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an issue in the
owlbot.pyfile added in #352 in that s.remove_staging_dirs() should only be called once after all the files are copied over. get_staging_dirs() will only return staging directories that exist.