Skip to content
This repository was archived by the owner on Mar 2, 2026. It is now read-only.

chore: migrate to owl bot#352

Merged
gcf-merge-on-green[bot] merged 3 commits into
masterfrom
owl-bot
May 12, 2021
Merged

chore: migrate to owl bot#352
gcf-merge-on-green[bot] merged 3 commits into
masterfrom
owl-bot

Conversation

@parthea
Copy link
Copy Markdown
Contributor

@parthea parthea commented May 10, 2021

This PR migrates from autosynth to owl bot. owl bot will save time for maintainers as it will automatically open PRs when there are updates in googleapis-gen without requiring maintainers to run synthtool to build the client from protos. Additionally, similar to autosynth, PRs will be automatically opened when there are template updates.

@parthea parthea requested review from a team May 10, 2021 14:07
@product-auto-label product-auto-label Bot added the api: firestore Issues related to the googleapis/python-firestore API. label May 10, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label May 10, 2021
Comment thread owlbot.py Outdated
@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 11, 2021
@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 12, 2021
@parthea parthea requested a review from busunkim96 May 12, 2021 15:44
@parthea parthea added the automerge Merge the pull request once unit tests and other checks pass. label May 12, 2021
@gcf-merge-on-green gcf-merge-on-green Bot merged commit 1f17794 into master May 12, 2021
@gcf-merge-on-green gcf-merge-on-green Bot deleted the owl-bot branch May 12, 2021 17:04
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 12, 2021
gcf-merge-on-green Bot pushed a commit that referenced this pull request May 25, 2021
There is [an issue](https://github.com/googleapis/python-firestore/blob/master/owlbot.py#L60) in the `owlbot.py` file added in #352 in that [s.remove_staging_dirs()](https://github.com/googleapis/synthtool/blob/master/synthtool/transforms.py#L309) should only be called once after all the files are copied over.  [get_staging_dirs()](https://github.com/googleapis/synthtool/blob/master/synthtool/transforms.py#L280) will only return staging directories that exist.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: firestore Issues related to the googleapis/python-firestore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants