fix: Split kwargs passed to gitlab client and graphql client#1151
Merged
amimas merged 6 commits intogitlabform:mainfrom Jan 4, 2026
Merged
fix: Split kwargs passed to gitlab client and graphql client#1151amimas merged 6 commits intogitlabform:mainfrom
amimas merged 6 commits intogitlabform:mainfrom
Conversation
thomascizeron
requested review from
TimKnight-DWP,
amimas,
gdubicki and
jimisola
as code owners
thomascizeron
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
thomascizeron
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1151 +/- ##
==========================================
+ Coverage 87.14% 88.31% +1.16%
==========================================
Files 73 73
Lines 3461 3465 +4
==========================================
+ Hits 3016 3060 +44
+ Misses 445 405 -40
🚀 New features to boost your workflow:
|
thomascizeron
force-pushed
the
fix/pass-kwargs-to-graphql
branch
from
589ba7a to
0c43a70
Compare
thomascizeron
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
thomascizeron
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
thomascizeron
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
thomascizeron
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
amimas
reviewed
Jan 3, 2026
Collaborator
amimas
left a comment
amimas
left a comment
There was a problem hiding this comment.
Thank you so much for looking into this. I only have one concern about maintaining a hard coded list of attributes for an external library. This is probably okay as a last resort. Would you be able to explore other alternatives?
I'm not experienced enough to suggest required code changes but left a comment below with a suggestion. Please take a look and let me know your thoughts or if you could try it out.
thomascizeron
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
thomascizeron
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
thomascizeron
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
thomascizeron
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
amimas
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
amimas
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
amimas
approved these changes
Jan 4, 2026
Collaborator
amimas
left a comment
amimas
left a comment
There was a problem hiding this comment.
Looks good. Thank you again for the quick fix. I'll merge it now and will look into releasing this soon along with the original feature you've contributed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked to #1140
Problem: Turns out python-gitlab dont pass kwargs to the graphql client, some kwargs would crash the init of the client.
Solution: Added explicit parameter whitelists in GitlabWrapper to pass parameters to the gitlab client or the graphql client
I have tested setting max_retries against a personnal gitlab instance and it worked. Dont know if an acceptance test would be useful here, let me know