feat: Allow for any kwarg to be passed to python-gitlab by GitlabWrapper#1140
Merged
amimas merged 4 commits intogitlabform:mainfrom Dec 21, 2025
Merged
Conversation
thomascizeron
requested review from
TimKnight-DWP,
amimas,
gdubicki and
jimisola
as code owners
thomascizeron
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
thomascizeron
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1140 +/- ##
==========================================
+ Coverage 87.17% 88.29% +1.11%
==========================================
Files 73 73
Lines 3463 3461 -2
==========================================
+ Hits 3019 3056 +37
+ Misses 444 405 -39
🚀 New features to boost your workflow:
|
amimas
reviewed
Dec 16, 2025
Collaborator
amimas
left a comment
amimas
left a comment
There was a problem hiding this comment.
Thank you so much for looking into this and the PR. Like the extra tests being included. Left some comments. Please let me know if you have any questions.
thomascizeron
commented
Dec 18, 2025
thomascizeron
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
thomascizeron
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
thomascizeron
commented
Dec 18, 2025
thomascizeron
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
thomascizeron
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
amimas
requested changes
Dec 18, 2025
thomascizeron
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
thomascizeron
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
thomascizeron
force-pushed
the
feat/allow-any-kwargs-to-python-gitlab
branch
from
c6ef449 to
3778048
Compare
thomascizeron
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
thomascizeron
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
amimas
approved these changes
Dec 21, 2025
Collaborator
amimas
left a comment
amimas
left a comment
There was a problem hiding this comment.
Looks good. Thanks again for working on this.
amimas
pushed a commit
that referenced
this pull request
Jan 4, 2026
In python-gitlab client, arbitrary parameters to graphql client is not accepted gracefully. This change fixes this issue by inspecting the library's signature and passing valid parameters to it. This way, we still maintain ability to pass accepted parameters/configurations through gitlabform's config. Related to #1140
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #1025
This PR enables GitlabForm to pass any additional configuration parameters from the
gitlabsection directly to the underlying python-gitlab Gitlab client. This provides users with flexibility to configure advancedpython-gitlabfeatures without requiring GitLabForm updates.