Skip to content

feat(material-experimental/drawer): add harness for mat-drawer - #17010

Merged
mmalerba merged 2 commits into
angular:masterfrom
crisbeto:drawer-harness
Sep 17, 2019
Merged

feat(material-experimental/drawer): add harness for mat-drawer#17010
mmalerba merged 2 commits into
angular:masterfrom
crisbeto:drawer-harness

Conversation

@crisbeto

@crisbeto crisbeto commented Sep 8, 2019

Copy link
Copy Markdown
Member

Follow-up from #16695. Adds a separate harness for mat-drawer and has mat-sidenav inherit from it.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent pr: merge safe target: patch This PR is targeted for the next patch release labels Sep 8, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 8, 2019

@mmalerba mmalerba left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments (Github seems to force me to put text here now)

Comment thread src/material-experimental/mdc-sidenav/harness/sidenav-harness.ts
@crisbeto

crisbeto commented Sep 9, 2019

Copy link
Copy Markdown
Member Author

Addressed the feedback @mmalerba.

@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 9, 2019
Follow-up from angular#16695. Adds a separate harness for `mat-drawer` and has `mat-sidenav` inherit from it.
@mmalerba mmalerba changed the title feat(material-experimental): add harness for mat-drawer feat(material-experimental/drawer): add harness for mat-drawer Sep 17, 2019
@mmalerba
mmalerba merged commit 2001965 into angular:master Sep 17, 2019
jelbourn pushed a commit to jelbourn/components that referenced this pull request Sep 24, 2019
…ar#17010)

Follow-up from angular#16695. Adds a separate harness for `mat-drawer` and has `mat-sidenav` inherit from it.

(cherry picked from commit 2001965)
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Oct 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants