feat(material-experimental): add sidenav test harness - #16695
Conversation
Adds a test harness for the sidenav.
crisbeto
added
P3
googlebot
added
the
cla: yes
mmalerba
left a comment
mmalerba
left a comment
There was a problem hiding this comment.
Interesting that there's a harness for the sub-component (sidenav) but not the parent (sidenav-container). I think it makes sense though, there's nothing interesting a user can really do with the container.
| * @dynamic | ||
| */ | ||
| export class MatSidenavHarness extends ComponentHarness { | ||
| static hostSelector = '.mat-sidenav'; |
There was a problem hiding this comment.
I think this could extend a MatDrawerHarness and just add the isFixedInViewport check.
There was a problem hiding this comment.
The reason why I didn't do anything with mat-drawer is because we haven't really exposed it anywhere. E.g. we don't have any live examples of it and it's nowhere in the docs from what I can tell.
There was a problem hiding this comment.
It doesn't have a separate page on our docs site, but it is actually discussed in the sidenav docs.
jelbourn
added
pr: lgtm
action: merge
|
I'm ok with figuring out the drawer thing in a followup sometime |
|
Anything for drawer can go in a follow-up if we decide to do that |
Adds a test harness for the sidenav. (cherry picked from commit 02a3f3e)
Follow-up from angular#16695. Adds a separate harness for `mat-drawer` and has `mat-sidenav` inherit from it.
Follow-up from angular#16695. Adds a separate harness for `mat-drawer` and has `mat-sidenav` inherit from it.
Follow-up from angular#16695. Adds a separate harness for `mat-drawer` and has `mat-sidenav` inherit from it.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
4 participants
Adds a test harness for the sidenav.