Fix the run destination OS name - #429
Open
floze-the-genius wants to merge 1 commit into
Open
floze-the-genius wants to merge 1 commit into
floze-the-genius wants to merge 1 commit into
Conversation
📝 WalkthroughWalkthrough
ChangesDevice OS rendering
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.gitignore:
- Line 4: Update the MacOSResults ignore rule to target only the generated
source path, while allowing
Tests/XCTestHTMLReportTests/Resources/MacOSResults.xcresult to remain tracked
for Package.swift and CoreTests.swift.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 9c491afe-3289-47a5-8de5-1b954d732de0
📒 Files selected for processing (10)
.gitignorePackage.swiftSources/XCTestHTMLReportCore/Classes/HTMLTemplates.swiftSources/XCTestHTMLReportCore/Classes/Models/RunDestination.swiftSources/XCTestHTMLReportCore/HTML/device.htmlTests/XCTestHTMLReportTests/CoreTests.swiftXCTestHTMLReportSampleApp/MacOSResultFixture/Package.swiftXCTestHTMLReportSampleApp/MacOSResultFixture/Sources/Fixture/Fixture.swiftXCTestHTMLReportSampleApp/MacOSResultFixture/Tests/FixtureTests/FixtureTests.swiftprepareTestResults.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ActionSDKRecord.nameinstead of hardcoding iOS.xcresultalongside the existing iOS fixtures and assert both rendered platform namesValidation
swift build --target XCTestHTMLReportCorepassestargetSDKRecord.name = macOS 15.5andoperatingSystemVersion = 15.5My local machine only has Command Line Tools, so the full Xcode-only fixture and test pipeline was run on the linked hosted macOS runner before opening this PR.
Fixes #364
AI assistance: Codex helped with implementation and validation; I reviewed the diff and verified every result reported above.
Summary by CodeRabbit
New Features
Bug Fixes