Glasgow Class 6 - Mandy Cheung - HTML/CSS - Week 2 - #590
Open
m4ndycheung wants to merge 32 commits into
Open
Conversation
Added mark up for basic content
Made hero image start at column line 1 and end at column line -1
removed max-width: 100% and changed to width: 100% - this was messing with my images.
centered items, put a border around social icons, changed colours
removed text decoration and changed link colour on hover to orange
Added image, text. and button. Updated the social icons by allowing the images not to be cropped by the border radius.
Removed border from buttons Adjusted font size for extended section as it seemed smaller than the figma image. Added orange colour to quotation marks Added a margin to bottom of extended section to create more space between section and footer
Fixed some issues with the social icons too
Made some fields required and added styling to submit button and margins to form fields
Labels appear above inputs. First name and last name appear side-by-side City and postcode also appear side-by-side Amended dropdown field. I used the incorrect tag before.
Added margins between fields so the fields are easier to read. Increased height of the input fields so the form is easier to use. Changed the radio button to orange.
Removed div containers to allow left and right containers to span across whole width.
Adjusted grid-column on left and right containers so there is a white margin on the left hand side.
Created grid for left container to position h1 and form elements on the left side.
To allow for more spacing around the top and bottom of the form heading and form
Link added to logo on store page to link back to home page.
The image now stays centered within the container and fills the space.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?
I already submitted this homework ("Glasgow Class 6 - Mandy Cheung - HTML/CSS - Week 2 Glasgow Class 6 - Mandy Cheung - HTML/CSS - Week 2 #558"). I wanted to try something different so I created a branch called Karma-grid-form. I'm not sure how to emrge it with the last one, so I'm creating a new pull request. Thanks!