Skip to content

Glasgow Class 6 - Mandy Cheung - HTML/CSS - Week 2 - #558

Open
m4ndycheung wants to merge 23 commits into
CodeYourFuture:masterfrom
m4ndycheung:master
Open

Glasgow Class 6 - Mandy Cheung - HTML/CSS - Week 2#558
m4ndycheung wants to merge 23 commits into
CodeYourFuture:masterfrom
m4ndycheung:master

Conversation

@m4ndycheung

Copy link
Copy Markdown

Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in HOW_TO_MARK.md in the root of this repository

Your Details

  • Your Name: Mandy Cheung
  • Your City: Glasgow
  • Your Slack Name: Mandy Cheung

Homework Details

  • Module: HTML / CSS
  • Week: 2

Notes

  • What did you find easy?

  • Plugging in the html markup

  • What did you find hard?

  • centering the 3 icons under the main content section

  • What do you still not understand?

  • I'm on the cusp of getting why I need to put containers around items but need to do more work on that!

  • Any other notes?

  • I definitely needed to start this earlier :') This was fun following an already-made design layout.

Added mark up for basic content
Made hero image start at column line 1 and end at column line -1
removed max-width: 100% and changed to width: 100% - this was messing with my images.
centered items, put a border around social icons, changed colours
removed text decoration and changed link colour on hover to orange
Added image, text. and button.

Updated the social icons by allowing the images not to be cropped by the border radius.
Removed border from buttons

Adjusted font size for extended section as it seemed smaller than the figma image.

Added orange colour to quotation marks

Added a margin to bottom of extended section to create more space between section and footer
Fixed some issues with the social icons too
Made some fields required and added styling to submit button and margins to form fields
Labels appear above inputs.

First name and last name appear side-by-side

City and postcode also appear side-by-side

Amended dropdown field. I used the incorrect tag before.
Added margins between fields so the fields are easier to read.

Increased height of the input fields so the form is easier to use.

Changed the radio button to orange.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant