Skip to content

ZA2 - Chandre De Wet - Karma Project #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chandredewet wants to merge 6 commits into
base: master
Choose a base branch
from
Open

ZA2 - Chandre De Wet - Karma Project #359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4e658ae
HTML of Karma completed.
chandredewet Jun 12, 2022
edc47d2
First attempt at Grid
chandredewet Jun 13, 2022
16f6616
header complete
chandredewet Jun 13, 2022
6ab440b
Improving Article Section
chandredewet Jun 13, 2022
e5c8e9d
Completed HTML CSS for Karma
chandredewet Jun 13, 2022
0f63567
Update index.html
chandredewet Jun 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
148 changes: 148 additions & 0 deletions css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
body {
font-family: 'Roboto', sans-serif;
-webkit-font-smoothing: antialiased;

}

/**
Expand All @@ -16,4 +17,151 @@ body {
* - When using Flexbox, remember the items you want to move around need to be inside a parent container set to 'display: flex'
*/

/*
Reset */

html, body {
margin:0;
}

/* *Navigation styles */

/*
Grid Info */

body {

height: 100vh;
width:100vw;
display: grid;
grid-template-columns: 33% 33% 33%;
grid-template-rows: 20% 80% 30% 40% 40%;
grid-template-areas:
"header header header"
"hero hero hero"
"head2 head2 head2"
"section section section"
"footer footer footer";

}

header {
grid-area: header;
display: flex;
justify-content: space-between;
padding: 40px;
}

.logo {
padding-left: 40px;
}

nav {
display: flex;
font-size: 1.5em;
padding-right: 40px;

}

nav ul {
list-style: none;
}

nav a {
text-decoration: none;
color:#5c5d5e;
}

nav a:hover {
text-decoration: none;
color:rgb(241 91 42);
}

.hero {
grid-area: hero;
background-image: url(/img/first-background.jpg);
background-size: cover;
color: white;
display: flex;
flex-direction: column;
align-items: center;
justify-content: center;
line-height: 0%;
}

h1 {
font-weight: 300;
font-size: 3.5em;
}

.hero p {
font-size: 2em;
font-weight: 300;
}

.hero button{
background-color:rgb(241 91 42);
border-radius: 5px;
padding: 20px 30px;
margin-top: 40px;
border: none;
}



h2 {
grid-area: head2;
color:#5c5d5e;
font-size: 2.5em;
font-weight: 400;
text-align: center;
margin-top: 150px;
}

.articlecontainer {
margin-top: 30px;
grid-area: section;
display: flex;
justify-content: center;
gap: 30px;
}

article {
text-align: center;

}
article img {
display: inline-block;
width:150px;
height:auto;
text-align: center;
}

article p {
width: 300px;
text-align: center;
font-size: 1.5em;
}

footer {
grid-area:footer;
text-align: center;
}

footer img {
width: 20px;
height: 20px;
padding:20px;
margin: 5px;
border: 1px solid rgba(230, 230, 230, 0.464);
border-radius: 50%;
}

hr {
width: 60%;
border: 0.5px solid rgba(203, 197, 197, 0.95);
}

.copyright {
color: rgba(203, 197, 197, 0.95);
}
82 changes: 82 additions & 0 deletions css/style_.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@

/* We are using the 'Roboto' font from Google. This has already been added to your HTML header */

body {
font-family: 'Roboto', sans-serif;
-webkit-font-smoothing: antialiased;
}

/**
* Add your custom styles below
*
* Remember:
* - Be organised, use comments and separate your styles into meaningful chunks
* for example: General styles, Navigation styles, Hero styles, Footer etc.
*
* - When using Flexbox, remember the items you want to move around need to be inside a parent container set to 'display: flex'
*/

/*
Reset */

html, body {
margin:0;
}

/* *Navigation styles */

/*
Grid Info */

body {
display: grid;
grid-template-columns: 33% 33% 33%;
grid-template-rows: 1fr auto 1fr 1 fr 1fr;
grid-template-areas:
"logo nav nav"
"hero hero hero"
"head2 head2 head2"
"sec1 sec2 sec3"
"footer footer footer";
}

.logo{
grid-area: logo;
background-color: green;
}

nav {
grid-area: nav;
display: flex;
background-color: pink;
}

.hero {
grid-area: hero;
background-color: yellow;
background-image: url(/img/first-background.jpg);
background-size: cover;
}
main h2 {
grid-area: head2;
}
article:nth-of-type(1) {
grid-area: sec1;
background-color: blue;
}

article:nth-of-type(2) {
grid-area: sec2;
background-color: red;
}

article:nth-of-type(3) {
grid-area: sec3;
background-color: purple;
}

footer {
grid-area:footer;
width: 100%;
height: 20%;
}
42 changes: 42 additions & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,47 @@
<!-- Remember: Use semantic HTML tags like <header>, <main>, <nav>, <footer>, <section> etc -->
<!-- All the images you need are in the 'img' folder -->

<header>

@M3ntalist M3ntalist Jun 16, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be great to see the whole semantic HTML tags at the beginning of your code.

<img class=logo src="/img/karma-logo.svg" alt="logo">
<nav>
<ul><a href="#"><strong>Meet Karma</strong></a></ul>
<ul><a href="#">How it Works</a></ul>

@M3ntalist M3ntalist Jun 16, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Chandre. Wouldn't be better to add a 'list'

  • under "unordered''
      instead of the way you added your code?

    •

    @chandredewet chandredewet Jun 16, 2022

    Copy link
    Copy Markdown
    Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Hi Kabelo, thanks for this feedback. I found it quite humorous that I didn't do a proper unordered list :) I guess that's the benefits of having others review your code!

    @M3ntalist M3ntalist Jun 16, 2022

    Copy link
    Copy Markdown

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Hi Chandre

    Yes, it's great to have a team buddy to review your work. Please review
    mine.

    <ul><a href="#">Store</a></ul>
    <ul><a href="#">Blog</a></ul>
    <ul><a href="#">Help</a></ul>
    <ul><a href="#">Login</a></ul>
    </nav>
    </header>

    @M3ntalist M3ntalist Jun 16, 2022

    Copy link
    Copy Markdown

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Your Nav bar, below, should be under

    :

    Blog

    <section class="hero">
    <h1>Introducing Karma</h1>
    <p>Bring Wifi with you, everywhere you go.</p>
    <button>Learn More</button>
    </section>
    <h2> Everyone needs a little Chandre.</h2>
    <section class="articlecontainer">

    @M3ntalist M3ntalist Jun 16, 2022

    Copy link
    Copy Markdown

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    section class="article-container", its much cleaner that way and clear to read

    <article>
    <img src="/img/icon-devices.svg" alt="different devices with different screensizes">
    <p>Internet for all devices</p>
    </article>
    <article>
    <img src="/img/icon-coffee.svg" alt="a cup with steam">
    <p>Boost your Productivity</p>
    </article>
    <article>
    <img src="/img/icon-refill.svg" alt="a petrol tank">

    @M3ntalist M3ntalist Jun 16, 2022

    Copy link
    Copy Markdown

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I like your sense of humour there for your alt="Petrol tank", why didn't you use something like "Device Icon"?

    <p>Pay as You Go</p>
    </article>
    </section>

    <footer>
    <hr>
    <p>Join us on</p>
    <img src="/img/twitter-icon.svg" alt="twitter icon">
    <img src="/img/facebook-icon.svg" alt="Facebook icon">
    <img src="/img/instagram-icon.svg" alt=" Instagram Logo" width="40"
    height="40">
    <p class="copyright"> Ⓒ Karma Mobility Inc.</p>
    </footer>

    </body>
    </html>
    61 changes: 61 additions & 0 deletions index_.html
    View file
    Open in desktop
    Original file line number Diff line number Diff line change
    @@ -0,0 +1,61 @@
    <!DOCTYPE html>

    @M3ntalist M3ntalist Jun 16, 2022

    Copy link
    Copy Markdown

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I am glad you added the proper HTML tags(Semantic)

    <html lang="en">
    <head>
    <meta charset="UTF-8">
    <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
    <title>Karma</title>
    <link href='https://fonts.googleapis.com/css?family=Roboto:400,500,300' rel='stylesheet' type='text/css'>
    <link rel="stylesheet" href="css/normalize.css">
    <link rel="stylesheet" href="css/style.css">
    <link rel="shortcut icon" type="image/x-icon" href="favicon.ico">
    </head>
    <body>

    <!-- Add your HTML markup here -->
    <!-- Remember: Use semantic HTML tags like <header>, <main>, <nav>, <footer>, <section> etc -->
    <!-- All the images you need are in the 'img' folder -->


    <div class="logo">logo</div>
    <nav>
    <ul><a href="#">Meet Karma</a></ul>
    <ul><a href="#">How it Works</a></ul>
    <ul><a href="#">Store</a></ul>
    <ul><a href="#">Blog</a></ul>
    <ul><a href="#">Help</a></ul>
    <ul><a href="#">Login</a></ul>
    </nav>

    <div class="hero">
    <h1>Introducing Karma</h1>
    <p>Bring Wifi with you, everywhere you go.</p>
    <button>Learn More</button>
    </div>

    <main>
    <h2> Everyone needs a little Karma.</h2>
    <section>
    <article>
    <img src="/img/icon-devices.svg" alt="different devices with different screensizes">
    <p>Internet for all devices</p>
    </article>
    <article>
    <img src="/img/icon-coffee.svg" alt="a cup with steam">
    <p>Internet for all devices</p>
    </article>
    <article>
    <img src="/img/icon-refill.svg" alt="a petrol tank">
    <p>Pay as You Go</p>
    </article>
    </section>
    </main>
    <footer>
    <p>Join us on</p>
    <p>Karma Mobility Inc.</p>
    <img src="/img/twitter-icon.svg" alt="twitter icon">
    <img src="/img/facebook-icon.svg" alt="Facebook icon">
    <img src="/img/instagram-icon.svg" alt=" Instagram Logo">
    </footer>

    </body>
    </html>