ZA2 - Chandre De Wet - Karma Project - #359
Conversation
First attempt at Grid
logo and nav resized, hover done for nav ul
Added another grid in main. Still need to resize images
Added copyright and footer detail Completed flexboxes for articles
Mathias02
left a comment
Mathias02
left a comment
There was a problem hiding this comment.
Please review my Karma project and pull a request to suggest changes.
M3ntalist
left a comment
M3ntalist
left a comment
There was a problem hiding this comment.
I like your CSS but it needs some TLC:
- Remember: Be organised, use comments and separate your styles into meaningful chunks
- for example; General styles, Navigation styles, Hero styles, Footer etc.
- Please add at the end of your CSS code your MEDIA QUERIES "Responsive web-design technique" so that we know what viewports you are targeting or aiming for.
| <img class=logo src="/img/karma-logo.svg" alt="logo"> | ||
| <nav> | ||
| <ul><a href="#"><strong>Meet Karma</strong></a></ul> | ||
| <ul><a href="#">How it Works</a></ul> |
There was a problem hiding this comment.
Hi Chandre. Wouldn't be better to add a 'list'
- instead of the way you added your code?
There was a problem hiding this comment.
Hi Kabelo, thanks for this feedback. I found it quite humorous that I didn't do a proper unordered list :) I guess that's the benefits of having others review your code!
There was a problem hiding this comment.
Hi Chandre
Yes, it's great to have a team buddy to review your work. Please review
mine.
| <!-- Remember: Use semantic HTML tags like <header>, <main>, <nav>, <footer>, <section> etc --> | ||
| <!-- All the images you need are in the 'img' folder --> | ||
|
|
||
| <header> |
There was a problem hiding this comment.
It will be great to see the whole semantic HTML tags at the beginning of your code.
| <ul><a href="#">Help</a></ul> | ||
| <ul><a href="#">Login</a></ul> | ||
| </nav> | ||
| </header> |
| <button>Learn More</button> | ||
| </section> | ||
| <h2> Everyone needs a little Karma.</h2> | ||
| <section class="articlecontainer"> |
There was a problem hiding this comment.
section class="article-container", its much cleaner that way and clear to read
| <p>Boost your Productivity</p> | ||
| </article> | ||
| <article> | ||
| <img src="/img/icon-refill.svg" alt="a petrol tank"> |
There was a problem hiding this comment.
I like your sense of humour there for your alt="Petrol tank", why didn't you use something like "Device Icon"?
| @@ -0,0 +1,61 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
I am glad you added the proper HTML tags(Semantic)
3 participants
I have completed but will still be keeping task open in case we are supposed to do level 2 as well. I have however completed the requirements of the main Readme, that we are to complete a desktop version of that website.