This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Feature: constant visibility#170
Merged
Ocramius merged 1 commit intozendframework:developfrom Oct 5, 2019
michalbundyra:feature/constant-visibility
Merged
Feature: constant visibility#170Ocramius merged 1 commit intozendframework:developfrom michalbundyra:feature/constant-visibility
Ocramius merged 1 commit intozendframework:developfrom
michalbundyra:feature/constant-visibility
Conversation
As we support already only PHP 7.1+ we can define visibility for constants.
Member
Author
|
@Ocramius will you consider this PR as BC break? |
weierophinney
approved these changes
Aug 28, 2019
Member
weierophinney
left a comment
weierophinney
left a comment
There was a problem hiding this comment.
Considering that the only versions of PHP this library supports also support constant visibility, and that the default when no visibility is provided is public, this seems like a BC-safe feature addition.
Member
Author
|
@Ocramius can I have also your review and opinion, please? |
Ocramius
approved these changes
Oct 5, 2019
michalbundyra
added a commit
that referenced
this pull request
Oct 5, 2019
michalbundyra
added a commit
that referenced
this pull request
Oct 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we support already only PHP 7.1+ we can define visibility for constants.
Added tests and updated current tests.
Default visibility is
public.