Fixes for SRL and SRA#3
Merged
Merged
Conversation
Neither instruction had the "... & 0x1f" mask that's needed to grab just the bottom 5 bits (SLL does have it). Also, SRA and SRL had the same implementation, which probably isn't right... :-)
Owner
|
Ah, right, thanks for pointing out. Will bump the version for that. |
Owner
|
This is in 0.6.3 now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neither instruction had the "... & 0x1f" mask that's needed to grab
just the bottom 5 bits (SLL does have it). Also, SRA and SRL had the
same implementation, which probably isn't right... :-)