refactor: warn on output directory cleanup failure - #518
Merged
tenthirtyam merged 1 commit intoJun 23, 2026
Merged
Conversation
- Adds `maxCleanupRetryAttempts` (5) and replaces the magic '5' in the cleanup loop with this constant. - Adds a log a warning if `dir.RemoveAll()` fails during `Run` instead of ignoring the error. These changes ensures that output directory removal failures are visible for debugging and the retry count is centralized. Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
github-actions
Bot
added
needs-review
tenthirtyam
deleted the
refactor/warn-on-output-directory-cleanup-failure
branch
June 23, 2026 19:02
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maxCleanupRetryAttempts(5) and replaces the magic '5' in the cleanup loop with this constant.dir.RemoveAll()fails duringRuninstead of ignoring the error.These changes ensures that output directory removal failures are visible for debugging and the retry count is centralized.
Type
fix: Bug Fixfeat: Feature or Enhancementdocs: Documentationrefactor: Refactoringchore: Build, Dependencies, Workflows, etc.other: Other (Please describe.)Breaking Changes?
Tests
Output:
Documentation
Issue References
Release Note
Additional Information