Skip to content

chore: add / update driver comments - #301

Merged
tenthirtyam merged 1 commit into
mainfrom
chore/add-update-driver-comments
Apr 30, 2025
Merged

tenthirtyam merged 1 commit into
mainfrom
chore/add-update-driver-comments

Conversation

@tenthirtyam

Copy link
Copy Markdown
Collaborator

Description

Adds/updates the comments in driver.go, as applicable, for correctness and clarity.

@tenthirtyam tenthirtyam added this to the v1.2.0 milestone Apr 30, 2025
@tenthirtyam tenthirtyam self-assigned this Apr 30, 2025
@tenthirtyam
tenthirtyam requested a review from a team as a code owner April 30, 2025 14:39
@tenthirtyam
tenthirtyam force-pushed the chore/add-update-driver-comments branch 2 times, most recently from b6a7ae9 to 27704bd Compare April 30, 2025 14:48

@JenGoldstrich JenGoldstrich left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to rebase this one, and I think our silly PR rules will dismiss this approval afterwards, feel free to @ me after you rebase and I'll re-approve

Adds/updates the comments in `driver.go`, as applicable, for correctness and clarity.

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@tenthirtyam
tenthirtyam force-pushed the chore/add-update-driver-comments branch from 27704bd to ea3129d Compare April 30, 2025 16:19
@tenthirtyam

Copy link
Copy Markdown
Collaborator Author

@JenGoldstrich Looks like it let it pass with the rebase. 🤷🏻‍♂️

i'll wait for the actions to pass and the S+M.

@tenthirtyam
tenthirtyam merged commit 38e85d0 into main Apr 30, 2025
@tenthirtyam
tenthirtyam deleted the chore/add-update-driver-comments branch April 30, 2025 16:23
@github-actions

Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jan 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants