Feat mcrouter#31
Conversation
stnguyen90
left a comment
stnguyen90
left a comment
There was a problem hiding this comment.
Great PR! 🤯 We left some comments during the review, please check them out. Please also make sure to run the formatter to fix the lint errors.
stnguyen90
left a comment
stnguyen90
left a comment
There was a problem hiding this comment.
Please make sure the linter and tests pass. You can include a screenshot of them passing in the tests section of the PR.
Also, do you have documentation on how to use mcrouter in PHP?
|
Hey, Due to time constraints, I'm going to mark this PR When it is merged, we'll contact you for Appwrite-specific Hacktoberfest swag. Thanks for helping us improve Appwrite! |
|
Hello @thecoderishi , Thank you for your contribution to Hacktoberfest 2023! We've noticed that your PR is still pending and requires some updates based on our engineering team's feedback. We would love to see your PR successfully merged and send you the Appwrite swag as a token of appreciation. To remain eligible for the swag, please address the pending suggestions and/or ensure the tests pass by Friday, November 17th. If the PR isn't updated by then, we will unfortunately have to close it due to the end of the Hacktoberfest event. Looking forward to your updates and thank you! |
|
Hello @gewenyu99, I was trying to find if there is any official or unofficial support for mcrouter, but there is nothing available now. Every instance from Docker has been removed already, hence I am not able to complete this feature. |
|
Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship. Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag. |
|
Thank you so much for the update and for organizing such a rewarding event! My Discord username is thecoderishi. Looking forward to receiving my Hacktoberfest swag and continuing to contribute to the community. Cheers! |
|
We'll contact soon, appreciate your patience. Throwing together a list of contacts and a form for your info. Thanks :) |
4 participants
What does this PR do?
Added caching with Mcrouter adapter.
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes