Skip to content

Feat: Migrate to Github Actions#30

Closed
faisalill wants to merge 21 commits into
utopia-php:masterfrom
faisalill:cicd-github-actions
Closed

Feat: Migrate to Github Actions#30
faisalill wants to merge 21 commits into
utopia-php:masterfrom
faisalill:cicd-github-actions

Conversation

@faisalill

Copy link
Copy Markdown

What's Changed:

Replace travis.yml with similar .github/workflows/tests.yml file.

Test Plans:

Opening a PR triggers tests:
Github Actions Test: faisalill#1
Travis Tests: https://app.travis-ci.com/github/utopia-php/cache/builds/259056517
Both have the same result.

Mention/Reference:

utopia-php/http#103

@2002Bishwajeet 2002Bishwajeet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor comments😁

Comment thread .github/workflows/tests.yml Outdated
Comment thread .github/workflows/tests.yml Outdated
Comment thread .github/workflows/tests.yml Outdated
Use ubuntu-latest rather than ubuntu-20.04
Change Run Tests step in github actions

@2002Bishwajeet 2002Bishwajeet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Code QL fails but I think that's for another PR to lookout for😉

@abnegate abnegate left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but we need to fix the CodeQL here before we can merge

@faisalill faisalill requested a review from abnegate August 12, 2023 14:12
Comment thread .github/workflows/tests.yml Outdated
@faisalill faisalill requested a review from abnegate August 15, 2023 02:50
Comment thread .github/workflows/tests.yml Outdated
@faisalill faisalill requested a review from abnegate August 20, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants