Skip to content

Added ability to exclude items by tags. #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgebal merged 5 commits into from
Oct 23, 2019
Merged

Added ability to exclude items by tags. #1008

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cdb6d3e
Added ability to exclude items by tags.
jgebal Oct 20, 2019
0d64c08
Changed syntax to avoid Oracle internal errors on 11.2 and 12.1
jgebal Oct 21, 2019
49c0768
Merge remote-tracking branch 'origin/develop' into feature/exclude_paths
jgebal Oct 21, 2019
f48e7e5
Improve documentation around tags
pesse Oct 22, 2019
2caa749
Use cli 3.1.8
pesse Oct 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Changed syntax to avoid Oracle internal errors on 11.2 and 12.1
  • Loading branch information
@jgebal
jgebal committed Oct 21, 2019
commit 0d64c080b614a62680e6440ff262e7f2b6788de3
30 changes: 17 additions & 13 deletions source/core/ut_suite_cache_manager.pkb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,21 +132,12 @@ create or replace package body ut_suite_cache_manager is
q'[included_tags as (
select c.obj.path as path
from suite_items c
where exists (
select * from table(c.obj.tags)
intersect
select * from table(:a_tag_list) where column_value not like '-%'
)
or 0 = (select count(*) from table(:a_tag_list) where column_value not like '-%')
where c.obj.tags multiset intersect :a_include_tag_list is not empty or :a_include_tag_list is empty
),
excluded_tags as (
select c.obj.path as path
from suite_items c
where exists (
select * from table(c.obj.tags)
intersect
select ltrim(column_value,'-') from table(:a_tag_list) where column_value like '-%'
)
where c.obj.tags multiset intersect :a_exclude_tag_list is not empty
),
suite_items_tags as (
select c.*
Expand All @@ -162,7 +153,7 @@ create or replace package body ut_suite_cache_manager is
)
),]'
else
q'[dummy as (select 'x' from dual where :a_tag_list is null and :a_tag_list is null and :a_tag_list is null),]'
q'[dummy as (select 'x' from dual where :a_include_tag_list is null and :a_include_tag_list is null and :a_exclude_tag_list is null),]'
end;
end;

Expand Down Expand Up @@ -205,10 +196,23 @@ create or replace package body ut_suite_cache_manager is
l_sql varchar2(32767);
l_suite_item_name varchar2(20);
l_tags ut_varchar2_rows := coalesce(a_tags,ut_varchar2_rows());
l_include_tags ut_varchar2_rows;
l_exclude_tags ut_varchar2_rows;
l_object_owner varchar2(250) := ut_utils.qualified_sql_name(a_object_owner);
l_object_name varchar2(250) := ut_utils.qualified_sql_name(a_object_name);
l_procedure_name varchar2(250) := ut_utils.qualified_sql_name(a_procedure_name);
begin

select column_value
bulk collect into l_include_tags
from table(l_tags)
where column_value not like '-%';

select ltrim(column_value,'-')
bulk collect into l_exclude_tags
from table(l_tags)
where column_value like '-%';

if a_path is null and a_object_name is not null then
select min(c.path)
into l_path
Expand All @@ -234,7 +238,7 @@ create or replace package body ut_suite_cache_manager is

execute immediate l_sql
bulk collect into l_results
using upper(l_object_owner), l_path, l_path, upper(a_object_name), upper(a_procedure_name), l_tags, l_tags, l_tags, a_random_seed;
using upper(l_object_owner), l_path, l_path, upper(a_object_name), upper(a_procedure_name), l_include_tags, l_include_tags, l_exclude_tags, a_random_seed;
return l_results;
end;

Expand Down