Include form-associated custom elements in form submissions - #807
Merged
Merged
Conversation
Contributor
|
Thanks @kmmbvnr. It turned out there was a lot of follow-up work necessary for form-associated custom elements to function outside of the submission, especially for reactive server forms. This has now been implemented in |
Contributor
Author
|
Great! The things that I like in Unpoly that it's batteries included. Currently I have to have a lot of user side code to handle forms reactivity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes the original issue #593.
I develop Viewflow.io and am evaluating alternatives to Turbolinks, Hotwire/Turbo, and htmx. During that work, I found a discrepancy in Unpoly. An
[up-submit]form dropped values from form-associated custom elements. A normal browser submission included them.What changes
up.Params.fromForm()now begins with nativeFormData(form). It uses the browser's form-data construction algorithm. This includes form-associated custom elements and values appended byformdatalisteners.The method then adds configured Unpoly fields that are absent from
form.elements. This keepsup.form.config.fieldSelectorsworking for non-native controls. It does not duplicate native or form-associated controls.This is a small submission-only change. It does not change
up.Params.fromContainer()or Unpoly's watcher behavior.Compatibility
Existing native controls keep browser submission semantics. Configured custom controls still submit when they expose
name,value, anddisabledproperties.Verification
formdatalisteners, form-associated custom elements, and configured non-native controls.npm run lint,npm run build-ci, and the focused Chromeup.Paramssuite.Authorship
This PR was AI-assisted and made with Codex Terra. I reviewed every line and take responsibility for the code.