Skip to content

feature(unlock-app): Foundational support for wallet funding feature - #15100

Merged
0xTxbi merged 5 commits into
masterfrom
foundational-wallet-funding
Nov 18, 2024
Merged

feature(unlock-app): Foundational support for wallet funding feature#15100
0xTxbi merged 5 commits into
masterfrom
foundational-wallet-funding

Conversation

@0xTxbi

@0xTxbi 0xTxbi commented Nov 18, 2024

Copy link
Copy Markdown
Member

Description

This PR introduces foundational changes for the new wallet funding feature, enabling users to fund their wallet directly from the settings. It also displays the user's current balance and shows the USD equivalent for clarity.

ScreenGrab

Screenshot 2024-11-18 at 16 10 55

Issues

Fixes #
Refs #

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

@0xTxbi
0xTxbi requested a review from julien51 November 18, 2024 15:32
@cla-bot cla-bot Bot added the cla-signed label Nov 18, 2024
Comment thread unlock-app/src/hooks/useEthPrice.ts Outdated

@julien51 julien51 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use our existing API to get $

@0xTxbi

0xTxbi commented Nov 18, 2024

Copy link
Copy Markdown
Member Author

Please use our existing API to get $

sure thing!

@0xTxbi
0xTxbi requested a review from julien51 November 18, 2024 17:10
@0xTxbi
0xTxbi merged commit 4b43655 into master Nov 18, 2024
@0xTxbi
0xTxbi deleted the foundational-wallet-funding branch November 18, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants