Skip to content

feature(unlock-app): Disable automatic wallet creation - #15068

Merged
0xTxbi merged 9 commits into
masterfrom
disable-automatic-wallet-creation
Nov 13, 2024
Merged

feature(unlock-app): Disable automatic wallet creation#15068
0xTxbi merged 9 commits into
masterfrom
disable-automatic-wallet-creation

Conversation

@0xTxbi

@0xTxbi 0xTxbi commented Nov 13, 2024

Copy link
Copy Markdown
Member

Description

This PR introduces a check for existing legacy (1.0 or 2.0) Unlock accounts. If no legacy account is found, a new wallet is created and linked to the user's Privy account. If a legacy account exists, no wallet is created; instead, the UI displays a message prompting the user to migrate their account, with a link to the migration page.

Issues

Fixes #
Refs #

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

@0xTxbi
0xTxbi requested a review from julien51 November 13, 2024 12:09
@cla-bot cla-bot Bot added the cla-signed label Nov 13, 2024

@julien51 julien51 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss

@0xTxbi

0xTxbi commented Nov 13, 2024

Copy link
Copy Markdown
Member Author

Let's discuss

sure thing!

@julien51 julien51 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I tink this works. Please test extensively on staging and make sure we don't trigger the callback twice?

@0xTxbi

0xTxbi commented Nov 13, 2024

Copy link
Copy Markdown
Member Author

ok I tink this works. Please test extensively on staging and make sure we don't trigger the callback twice?

sure thing! got it!

@0xTxbi
0xTxbi merged commit e1c3fd7 into master Nov 13, 2024
@0xTxbi
0xTxbi deleted the disable-automatic-wallet-creation branch November 13, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants