Add Codecov badge and exclude non-source files from coverage - #41
Merged
Conversation
The README gets a Codecov badge next to the CI badge (coverage uploads were already wired up in test.yml via codecov-action). Without an explicit exclude list, vitest's v8 coverage counted the browser gate scripts (scripts/*.mjs) and Storybook stories, reporting 14% overall. Those files aren't unit-testable (the gates run in Chromium; stories are exercised by the Storybook smoke/visual gates), so exclude them — coverage now reports the real source figure: 95%. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
ivoIturrieta
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
test.yml(codecov/codecov-action@v4+CODECOV_TOKEN), so only the badge was missing.coverage.excludelist topackages/react/vitest.config.tsso the uploaded report reflects library source only.Why the exclude list
Without it, vitest's v8 provider counts every file in the package, including:
scripts/*.mjs— the browser E2E, CSP probe, and visual-drift gate scripts (run in Chromium, not unit-testable)**/*.stories.tsx— Storybook stories (exercised by the Storybook smoke + visual gates instead)Those files sit at 0% and dwarf the real source, so the report read 14.27%. With the excludes, the same test run reports 95.45% statements — the badge will now show the genuine source coverage.
Verification
pnpm test:coverage: 36 files, 450 tests pass; coverage table now readsAll files | 95.45 | 82.37 | 97.8 | 95.45.🤖 Generated with Claude Code
📖 Storybook Preview: https://unlayer.github.io/elements/pr/41/