Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

Added docs for IAM roles and new target auth specs#332

Merged
jmcx merged 2 commits into
mainfrom
AWS-target-auth-changes-1238
Jan 6, 2023
Merged

Added docs for IAM roles and new target auth specs#332
jmcx merged 2 commits into
mainfrom
AWS-target-auth-changes-1238

Conversation

@jmcx
Copy link
Copy Markdown
Contributor

@jmcx jmcx commented Jan 5, 2023

No description provided.

@jmcx jmcx requested a review from tzununbekov January 5, 2023 15:51
@jmcx
Copy link
Copy Markdown
Contributor Author

jmcx commented Jan 5, 2023

@tzununbekov I though I'd add examples for IAM roles in the component docs.
I noticed that SNSSource doesn't have IAMrole listed in its spec, do you think someone just forgot to update the spec or was it not implemented?

@jmcx jmcx linked an issue Jan 5, 2023 that may be closed by this pull request
@tzununbekov
Copy link
Copy Markdown
Member

@tzununbekov I though I'd add examples for IAM roles in the component docs.
I noticed that SNSSource doesn't have IAMrole listed in its spec, do you think someone just forgot to update the spec or was it not implemented?

All correct, SNS source doesn't have IAM role support in the adapter - not sure why though, maybe there is some technical constraints that would not allow that.

Comment thread docs/sources/awscloudwatch.md Outdated
Comment on lines +52 to +58
Alternatively you can use an IAM role for authentication instead of an access key and secret (Amazon EKS only):

```yaml
auth:
iamrole: arn:aws:iam::123456789012:role/foo
```

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we already have it somewhere, but do you think it worth putting the link to official doc about IAM roles support for SA (link)?
Asking because this one-liner hides a lot of configuration that have to be done by user on AWS side, leaving the impression that having any IAM role there is enough.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@jmcx
Copy link
Copy Markdown
Contributor Author

jmcx commented Jan 6, 2023

Created an issue to track IAM support for AWSSNS source triggermesh/triggermesh#1265

@jmcx jmcx merged commit ab5fe04 into main Jan 6, 2023
@jmcx jmcx deleted the AWS-target-auth-changes-1238 branch January 6, 2023 08:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs for iam role support in targets, and update aws target auth spec

2 participants