refactor(test): テストのリファクタリング - #2
Draft
takejohn wants to merge 6 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
expect.extend()を用いて、expect()が返すAssertionにtoEqualValueOfメソッドを追加します(実装:test/setup/index.ts, 型定義:vitest.d.ts)。このメソッドはAiScriptの値が等しいことを確認するためにeq()関数の代わりに用います。test/testutils.tsのeq()関数を削除します。eq(actual, expected)を、expect(actual).toEqualValueOf(expected)に置き換えます。test/syntax.tsのmetaテストスイートに含まれるeq(actual, expected)の呼び出しは、引数がAiScriptの値ではないため、expect(actual).toStrictEqual(expected)に置き換えます。eq関数はtypeとvalueプロパティのみ比較を行うため、以前は正しく比較を行えていませんでした。tsconfig.jsonにテストファイルを含め、エディタにおいてテストファイルの型チェックが働くようにします。ビルド時(npm scriptsのts-esmとts-dts)にはtsconfig.build.jsonを使用します。Why
eq()関数を一つのassertionに置き換えることで、assertionのカウントを正確に把握できるようにし、expect.hasAssertions()などを扱いやすくします。test/syntax.tsのmetaテストスイートのような誤りを防ぎます。Additional info (optional)
(変更が若干大きすぎたので後で分けてPRを出すためのメモ)