Skip to content

Reviving Lee's Refresh now#250

Merged
graysonarts merged 8 commits intotableau:developmentfrom
graysonarts:refresh-now
Jan 15, 2018
Merged

Reviving Lee's Refresh now#250
graysonarts merged 8 commits intotableau:developmentfrom
graysonarts:refresh-now

Conversation

@graysonarts
Copy link
Copy Markdown
Contributor

@graysonarts graysonarts commented Jan 15, 2018

There has been an outstanding change for refresh now for a while. This is to finally get this into the code base.

Copy link
Copy Markdown
Collaborator

@t8y8 t8y8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we already have test coverage on this?

Comment thread tableauserverclient/models/job_item.py Outdated
all_tasks_xml = parsed_response.findall(
'.//t:job', namespaces=ns)

all_tasks = (JobItem._parse_element(x, ns) for x in all_tasks_xml)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: You can just do a list comprehension since you just convert to a lista line later.

Copy link
Copy Markdown
Collaborator

@t8y8 t8y8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Copy Markdown
Contributor

@shinchris shinchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@graysonarts graysonarts merged commit ec00d79 into tableau:development Jan 15, 2018
@graysonarts graysonarts deleted the refresh-now branch January 15, 2018 21:38
@graysonarts graysonarts mentioned this pull request Jan 16, 2018
vchavatapalli pushed a commit to vchavatapalli/server-client-python that referenced this pull request May 5, 2026
* Update Change Log

* Add refresh and jobs endpoints

* Fixing pycodestyle failures

* Run pycodestyle on samples also

* Add sample for refresh and a useful tool to get the id for datasources and workbooks

* Actually checking in list.py this time

* more pep8 fixes

* Addressing Tyler's feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants