Conversation
✅ Deploy Preview for svelteplot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-532
# or install the specific version
npm install svelteplot@0.12.0-pr-532.0 |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 925ec8d460
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-532
# or install the specific version
npm install svelteplot@0.12.0-pr-532.1 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ccb62e3d13
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-532
# or install the specific version
npm install svelteplot@0.12.0-pr-532.2 |
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-532
# or install the specific version
npm install svelteplot@0.12.0-pr-532.3 |
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-532
# or install the specific version
npm install svelteplot@0.12.0-pr-532.4 |
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-532
# or install the specific version
npm install svelteplot@0.12.0-pr-532.5 |
1 participant
Summary
Densitymark for two-dimensional kernel density estimationcontourDensity, renders iso-density contour bands via marching squares andgeoPathfill="density"/stroke="density"to map density levels through the plot's color scalefx/fy— thresholds are derived from the global density maximum across all facet groups so the color scale stays consistent between panelsweightchannel for weighted KDEbandwidth(Gaussian kernel σ in pixels, default 20) andthresholds(count or explicit array)canvasprop (backed byDensityCanvas.svelte, following theGeoCanvaspattern)fxVal/fyVal), preventing a spuriousundefinedpanel from appearing in faceted plotsDateobjects from millisecond min/max values soinferScaleTypecorrectly returns'time'New files
src/lib/marks/Density.sveltesrc/lib/marks/helpers/DensityCanvas.sveltesrc/routes/marks/density/+page.mdsrc/routes/marks/density/+page.tssrc/routes/examples/density/basic.sveltesrc/routes/examples/density/filled.sveltesrc/routes/examples/density/faceted.sveltesrc/tests/density.test.tssrc/tests/density.test.sveltesrc/tests/densitySharedScale.test.sveltestatic/data/cherryblossom.csvModified files
src/lib/marks/index.ts— exportDensitysrc/lib/types/mark.ts— add'density'toMarkTypesrc/lib/types/plot.ts— addDensityimport anddensitykey toPlotDefaultssrc/lib/marks/ColorLegend.svelte— minor related fixsrc/routes/marks/density/+page.md— docs: bandwidth, thresholds, faceting, weight, temporal examplesrc/routes/transforms/density/+page.md— cross-link to 2D density markTest plan
pnpm test— all unit tests passpnpm check— 0 type errorsfill="density"with a color scheme shows filled bandscanvasprop renders contour bands to a<canvas>element🤖 Generated with Claude Code