fix: remove double margin offset in Pointer and HTMLTooltip#511
Merged
gka merged 1 commit intofix/tooltip-facet-positioningfrom Mar 2, 2026
Merged
fix: remove double margin offset in Pointer and HTMLTooltip#511gka merged 1 commit intofix/tooltip-facet-positioningfrom
gka merged 1 commit intofix/tooltip-facet-positioningfrom
Conversation
The quadtree already stores points in scale-range space which includes margins, so adding marginLeft/marginTop to mouse coordinates caused a double offset that prevented point selection with non-zero margins. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Deploy Preview for svelteplot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #509.
+ marginLeft/+ marginTopfrom mouse-to-SVG coordinate conversion inPointer.svelteandHTMLTooltip.svelteprojectX/projectY), so adding margins again caused a double offset that prevented point selection when margins > 0margin: 20that fails before the fix and passes afterTest plan
selects nearest point with non-zero margins(margin=20, verifies point is found)pnpm checkcleanpnpm lintclean🤖 Generated with Claude Code