fix: refactor unused expressions into proper statements#504
Merged
Conversation
- Refactor comma expressions into separate statements in arrowPath.ts, bollinger.ts, and density.ts - Change bare `rest;` to `void rest;` in theme components for Svelte reactivity tracking Fixes all 10 no-unused-expressions oxlint warnings. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Deploy Preview for svelteplot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
gka
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
((sum += value), (sumSquared += value ** 2))) into separate statementsrest;tovoid rest;in Svelte theme components for explicit reactivity trackingno-unused-expressionsoxlint warnings across 6 filesFiles changed
src/lib/helpers/arrowPath.ts— 3 comma expressions → separate statementssrc/lib/transforms/bollinger.ts— 3 comma expressions → separate statementssrc/lib/transforms/density.ts— 1(lo = hi) || ...→lo = hi || ...src/theme/components/GlobalLayout.svelte—rest;→void rest;src/theme/components/NavItem.svelte—rest;→void rest;src/theme/components/IconifyIcon.svelte—rest;→void rest;Test plan
pnpm exec oxlint --type-aware— 0no-unused-expressionswarningspnpm test— all tests passpnpm check— 0 svelte-check errors🤖 Generated with Claude Code