fix: remove redundant type constituents from union types#502
Merged
Conversation
- ColorScheme | string → ColorScheme | (string & {}) to preserve autocomplete
- CSS.Property.FontSize | number → CSS.Property.FontSize<number>
- '_self' | '_blank' | ... | string → ... | (string & {})
- RawValue | boolean → RawValue (boolean already in RawValue)
- Kernel | string → Kernel (private function, string not needed)
Fixes all 11 no-redundant-type-constituents oxlint warnings.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Deploy Preview for svelteplot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gka
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
no-redundant-type-constituentsoxlint warnings across 4 files(string & {})pattern to preserve IDE autocomplete while removing redundantstringfrom unions that already contain string literal subtypesbooleanfromRawValue | boolean(already included inRawValue)CSS.Property.FontSize<number>generic instead ofCSS.Property.FontSize | numberKernel | string→Kernelfor privatemaybeKernel()functionFiles changed
src/lib/helpers/colors.ts— 4 function signaturessrc/lib/helpers/group.ts— 1 type annotationsrc/lib/types/mark.ts— 2 type properties (fontSize, target)src/lib/transforms/density.ts— 1 function signatureTest plan
pnpm exec oxlint --type-aware— 0no-redundant-type-constituentswarningspnpm test— all tests passpnpm check— 0 svelte-check errors🤖 Generated with Claude Code