types: Fix svelte-check issues in BarX, BarY, RuleX, and RuleY#488
Conversation
- BarX/BarY: Add DataRecord import; fix class default null→''; fix data
default {} cast; cast d.x1/x2/y/y1/y2/x as number in Math.min/max
and arithmetic; cast options as BaseMarkProps<DataRecord> &
BaseRectMarkProps<DataRecord> for RectCanvas and RectPath
- RuleX/RuleY: Add DataRow import; cast data as DataRow[] in
recordizeX/Y call; remove redundant {...markProps} from <Mark> spread
(fixes filter type variance error); cast args as any for RuleCanvas
options and resolveStyles; add as number casts to inset/insetTop/
insetBottom/insetLeft/insetRight const declarations
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
✅ Deploy Preview for svelteplot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-488
# or install the specific version
npm install svelteplot@0.10.3-pr-488.0 |
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-488
# or install the specific version
npm install svelteplot@0.10.3-pr-488.1 |
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-488
# or install the specific version
npm install svelteplot@0.10.3-pr-488.2 |
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-488
# or install the specific version
npm install svelteplot@0.10.3-pr-488.3 |
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-488
# or install the specific version
npm install svelteplot@0.10.3-pr-488.4 |
1 participant
resolves #417
resolves #418
resolves #443
resolves #444
Summary
BarX.svelte,BarY.svelte,RuleX.svelte, andRuleY.svelte(39 errors → 0)DataRecordimport; fixclassdefaultnull→''; fixdatadefault{}cast; castd.x1/x2/y/y1/y2/xasnumberinMath.min/Math.maxand arithmetic expressions; castoptionsasBaseMarkProps<DataRecord> & BaseRectMarkProps<DataRecord>when passing toRectCanvasandRectPathDataRowimport; castdata as DataRow[]inrecordizeX/recordizeYcall; remove redundant{...markProps}from<Mark>spread (fixesfiltertype variance error — all options already flow through{...args}); castargs as anyforRuleCanvasoptions andresolveStyles; addas numbercasts toinset/insetTop/insetBottom/insetLeft/insetRight{@const}declarationsTest plan
pnpm check— no errors in the four affected filespnpm test— run unit testspnpm lint— Prettier + ESLint🤖 Generated with Claude Code