test: add unit tests for Vector/Spike marks (#171)#381
Merged
gka merged 1 commit intosvelteplot:mainfrom Feb 16, 2026
Merged
Conversation
Add 13 tests covering Vector (8) and Spike (5) mark components: - Rendering correct number of paths per datum - Valid shape geometry (M/L path commands) - Transform attributes (translate/rotate) - Custom stroke/fill styling - All three shape variants (arrow, spike, arrow-filled) - Anchor option behavior (start vs middle) - Default Spike styling (currentColor stroke) - Empty data handling Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Deploy Preview for svelteplot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
gka
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vectormark covering path rendering, shape geometry, transforms, styling (stroke/fill), all 3 shape variants (arrow, spike, arrow-filled), anchor behavior, and empty dataSpikemark covering path rendering, default spike shape, default/custom stroke styling, and empty data.test.sveltewrapper +.test.svelte.tspatternReplaces #380 (which included a duplicate Bollinger commit from the parent branch).
Closes #171
Test plan
bun run test src/tests/vector.test.svelte.ts src/tests/spike.test.svelte.ts— 13 tests passbun run test— full suite passes (480 tests, no regressions)🤖 Generated with Claude Code