Skip to content

test: add unit tests for Rect/RectX/RectY marks#372

Merged
gka merged 2 commits intosvelteplot:mainfrom
ljodea:test/rect-168
Feb 16, 2026
Merged

test: add unit tests for Rect/RectX/RectY marks#372
gka merged 2 commits intosvelteplot:mainfrom
ljodea:test/rect-168

Conversation

@ljodea
Copy link
Copy Markdown
Collaborator

@ljodea ljodea commented Feb 15, 2026

Summary

  • Adds 19 unit tests (7 Rect + 6 RectX + 6 RectY) covering rendering, positioning, style passthrough, borderRadius, inset, and edge cases
  • Follows established test patterns from BarX/Cell/LineX tests
  • Uses rect[transform] selector to disambiguate mark rects from FacetGrid background rect

Closes #168

Test plan

  • All 19 new tests pass
  • Full test suite passes (470 tests, 0 failures)
  • Lint clean

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@netlify
Copy link
Copy Markdown

netlify bot commented Feb 15, 2026

Deploy Preview for svelteplot ready!

Name Link
🔨 Latest commit 7f6732e
🔍 Latest deploy log https://app.netlify.com/projects/svelteplot/deploys/69938c3f420698000888b375
😎 Deploy Preview https://deploy-preview-372--svelteplot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Contributor

@gka gka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@gka gka merged commit e73f352 into svelteplot:main Feb 16, 2026
8 checks passed
@ljodea
Copy link
Copy Markdown
Collaborator Author

ljodea commented Feb 17, 2026

thanks!

thanks for making all this @gka . you did great work!

@ljodea ljodea deleted the test/rect-168 branch February 17, 2026 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add unit tests for Rect/RectX/RectY marks

2 participants