Conversation
✅ Deploy Preview for svelteplot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f81c354506
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (orientation === 'vertical') { | ||
| const x = datum.x; | ||
| if (x == null) continue; | ||
|
|
There was a problem hiding this comment.
Canvas rendering ignores the per-datum dx/dy offsets when explicit x/y channels are provided. In SVG mode, TickX/TickY always apply dx/dy via the transform="translate(...)" regardless of whether x/y are set, so users can shift ticks uniformly. In the canvas path, datum.x/datum.y are used directly, and the offsets are only included in the fallback branches when options.y/options.x are null. This means dx/dy silently stop working for canvas ticks whenever x/y are set, producing mismatched output between SVG and canvas.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
dx/dy is already applied for scaled channels, see here https://github.com/svelteplot/svelteplot/blob/feat/canvas-tick-mark/src/lib/Mark.svelte#L286-L289
|
TypeScript error report:
Svelte TypeScript error report:
|
1 participant
resolves #34
Summary
.containerand.two-colsstyles into the global examples layout for reuseTesting