Merged
Conversation
✅ Deploy Preview for svelteplot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eda9a94e53
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
gka
force-pushed
the
feat/line-marker-scale
branch
from
e5f04c8 to
ab4e328
Compare
|
TypeScript error report:
Svelte TypeScript error report:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #321
This pull request introduces a new
markerScaleproperty for line and link marks, allowing users to control the size of markers relative to the line stroke width. The changes include updates to the marker rendering logic, documentation, and tests to support and demonstrate this new feature.Marker scaling feature:
markerScaleproperty toLine,Link, and marker-related components and types, allowing customization of marker size relative to stroke width. (src/lib/marks/Line.svelte,src/lib/marks/Link.svelte,src/lib/marks/helpers/Marker.svelte,src/lib/marks/helpers/MarkerPath.svelte,src/lib/types/index.ts, [1] [2] [3] [4] [5]markerScalefactor to marker width, height, and stroke width, ensuring accurate scaling.Documentation updates:
markerScaleproperty in both API and feature documentation, including usage examples and explanations. (src/routes/api/marks/+page.md,src/routes/features/markers/+page.md, [1] [2] [3]Testing improvements:
markerScale. (src/tests/line.test.svelte.ts,src/tests/link.test.svelte,src/tests/link.test.svelte.ts, [1] [2] [3]UI enhancements:
markerScaleinteractively. (src/routes/features/markers/+page.md, [1] [2] [3]These changes make marker customization more flexible and improve both the developer and user experience when working with line and link marks.