fix: pass class name to base axis helper components#331
Merged
Conversation
|
TypeScript error report:
Svelte TypeScript error report:
|
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-331
# or install the specific version
npm install svelteplot@0.9.1-pr-331.0 |
✅ Deploy Preview for svelteplot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
TypeScript error report:
Svelte TypeScript error report:
|
|
📦 Preview package for this PR is published! Version: Install it with: npm install svelteplot@pr-331
# or install the specific version
npm install svelteplot@0.9.1-pr-331.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates how custom CSS classes are applied to axis components and improves type safety for axis props. It also adds new tests to ensure that custom classes are correctly set on both X and Y axes.
Axis component improvements:
AxisX.svelteandAxisY.svelteto pass the CSS class using theclassattribute instead ofclassName, aligning with Svelte conventions. [1] [2]classattribute inBaseAxisX.svelteandBaseAxisY.svelteto allowstring | undefined, improving type safety and flexibility. [1] [2]Testing enhancements:
axisX.test.tsandaxisY.test.tsto verify that custom class names are correctly applied to axis elements, ensuring the new behavior works as expected. [1] [2]