Skip to content

Support new version of AP242 STEP schema #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
starseeker wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

Support new version of AP242 STEP schema #470

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8cc8fc7
Set up the newer (non-working) ap242 exp file
starseeker Feb 6, 2026
93369ce
Add baseline test for PE056 error in AP242 schema parsing (#10)
Copilot Feb 6, 2026
975a74d
Fix PE056: Deep aggregate unwrapping for QUERY resolution (#12)
Copilot Feb 6, 2026
a01c338
Implement TREAT expression for SELECT type narrowing per ISO 10303-11…
Copilot Feb 6, 2026
aa79dbf
Implement flow-sensitive SELECT narrowing for TYPEOF guards in AND ex…
Copilot Feb 7, 2026
befb85f
Add TREAT-based AP242 schema variant for standards compliance compari…
Copilot Feb 9, 2026
4d03347
Put TREAT modded ap242 into a separate directory
starseeker Feb 9, 2026
7a038d1
Remove testing files
starseeker Feb 9, 2026
966fb9d
Remove md implementation files
starseeker Feb 9, 2026
e1de455
Add functional tests for AP242 styled_item with both narrowing approa…
Copilot Feb 9, 2026
57a929c
Add adjustment per suggestion from TRThurman to make SCHEMA_CMLIST id…
starseeker Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Put TREAT modded ap242 into a separate directory
  • Loading branch information
@starseeker
starseeker committed Feb 9, 2026
commit 4d03347df68b8de40fa2aacdf53faa062b7b5c19
0 data/ap242/242_mim_lf_treat.exp → data/ap242treat/242_mim_lf_treat.exp
View file
Open in desktop
File renamed without changes.
28 changes: 4 additions & 24 deletions data/ap242/README.md → data/ap242treat/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,9 @@
# AP242 Schema Files
# AP242 TREAT Schema File

This directory contains two versions of the AP242 (ISO 10303-242) schema.
This directory contains an altered version of the AP242 (ISO 10303-242) schema.

## Files

### `242_mim_lf.exp` (Original)
- **Status**: Original ISO schema with non-standard parsing requirement
- **Size**: 54,756 lines
- **Parsing**: Requires STEPcode's flow-sensitive type narrowing extension
- **Standards**: Contains pattern that needs implicit type narrowing (non-standard)

### `242_mim_lf_treat.exp` (Standards-Compliant)
- **Status**: Corrected version using TREAT expression
- **Size**: 54,756 lines
- **Parsing**: Fully ISO 10303-11 compliant
- **Standards**: Uses explicit TREAT expression for type narrowing
It is corrected to avoid the non-standard parsing requirement of the original
by using explicit TREAT expression for type narrowing

## The Difference

Expand All @@ -30,8 +19,6 @@ QUERY(it <* item | ...)
QUERY(it <* TREAT(item AS set_representation_item) | ...)
```

## Why Two Versions?

### Historical Context
The original AP242 schema contains a WHERE rule that:
1. Checks if `item` (a SELECT type) is a `SET_REPRESENTATION_ITEM`
Expand Down Expand Up @@ -68,13 +55,6 @@ Expected output:

For detailed comparison, see `doc/ap242-comparison.md`.

## Which Version to Use?

- **For STEPcode**: Both work equally well
- **For portability**: Use the TREAT version (`242_mim_lf_treat.exp`)
- **For ISO compliance**: Use the TREAT version (`242_mim_lf_treat.exp`)
- **For historical reference**: The original is preserved as `242_mim_lf.exp`

## Related Documentation

- `doc/ap242-comparison.md` - Detailed comparison and analysis
Expand Down
4 changes: 2 additions & 2 deletions test/compare_ap242_versions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,10 @@ fi
# Test TREAT version (standards-compliant)
echo ""
echo -e "${BLUE}Testing TREAT-based AP242 schema (standards-compliant)...${NC}"
echo " Input: data/ap242/242_mim_lf_treat.exp"
echo " Input: data/ap242treat/242_mim_lf_treat.exp"
echo " Output: $TREAT_OUTPUT"

if "$BUILD_DIR/bin/exp2cxx" "$REPO_ROOT/data/ap242/242_mim_lf_treat.exp" "$TREAT_OUTPUT" > "$TREAT_OUTPUT/exp2cxx.log" 2>&1; then
if "$BUILD_DIR/bin/exp2cxx" "$REPO_ROOT/data/ap242treat/242_mim_lf_treat.exp" "$TREAT_OUTPUT" > "$TREAT_OUTPUT/exp2cxx.log" 2>&1; then
echo -e "${GREEN}✓ TREAT version parsed successfully${NC}"
else
echo -e "${RED}✗ TREAT version failed to parse${NC}"
Expand Down