Fix #5346: Add MongoDatabaseFactory support to MongoJobRepositoryFactoryBean#5352
Open
nikitanagar08 wants to merge 1 commit intospring-projects:mainfrom
Open
Conversation
nikitanagar08
force-pushed
the
fix-5346-mongodb-mapkeydotreplacement-clean
branch
from
c19ea1d to
3516d11
Compare
…bRepositoryFactoryBean This commit addresses the issue where users had to create a separate MongoTemplate with MapKeyDotReplacement configuration specifically for Spring Batch. Changes: - Add setMongoDatabaseFactory() method to MongoJobRepositoryFactoryBean - Deprecate setMongoOperations() in favor of setMongoDatabaseFactory() - Create MongoTemplate internally with required MapKeyDotReplacement config - Update MongoJobExplorerFactoryBean with the same changes This allows users to simply provide a MongoDatabaseFactory instead of creating a separate MongoTemplate for Spring Batch. Signed-off-by: Nikita Nagar <permanayan84@gmail.com>
nikitanagar08
force-pushed
the
fix-5346-mongodb-mapkeydotreplacement-clean
branch
from
3516d11 to
0e1b887
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #5346 by adding support for
MongoDatabaseFactoryinMongoJobRepositoryFactoryBeanandMongoJobExplorerFactoryBean.Problem
Users had to create a separate
MongoTemplatewithMapKeyDotReplacementconfiguration specifically for Spring Batch, which was cumbersome.Solution
setMongoDatabaseFactory()method to accept aMongoDatabaseFactoryMongoTemplateinternally with properMapKeyDotReplacementconfigurationsetMongoOperations()in favor of the new approachMongoJobExplorerFactoryBeanBenefits
MongoDatabaseFactoryinstead of creating a separateMongoTemplateMapKeyDotReplacementconfiguration is handled automaticallysetMongoOperations()method