Skip to content

Bug in Arduino Code#141

Closed
TeeVoe wants to merge 3 commits into
sparkfun:masterfrom
TeeVoe:master
Closed

Bug in Arduino Code#141
TeeVoe wants to merge 3 commits into
sparkfun:masterfrom
TeeVoe:master

Conversation

@TeeVoe

@TeeVoe TeeVoe commented Feb 24, 2018

Copy link
Copy Markdown

Changed the bug for the Arduino code and changed the byte to in because analogRead should return an integer value. As a side note and question. I made this edit using the text editor Atom. Is this the reason it made a bunch of other line editing? The only thing I did to the Arduino code was change byte to int, but when I committed, I saw that it had a slew of other line changes that I didn't make. They don't affect the readability or function of the code I don't think, but I'm not really sure what happened.

Changed byte to int on line 24
Implementing bug back into code
Changed byte to integer. analogRead returns an integer.
@bboyho

bboyho commented Feb 6, 2019

Copy link
Copy Markdown

I actually use ConTEXT Editor as a quick and simple editor. I've used it ever since my assembly language class at CU. I rarely use the Atom editor but that's a matter of personal preference. ;P

It's possible that something was added to the code as "hidden characters" when the Arduino sketch file was saved in Atom. I've seen this happen at SparkFun when our QC department moves a batch file from Windows to a Linux image on a Raspberry Pi. I even see it when editing our tutorials in the background. Doing a search online, it looks like you might be able to configure this setting in the Atom editor to prevent changes to other lines:

Thanks for contributing back! This looks great! But I'm going to leave this bug in place so that the tutorial continues to work. ;)

@bboyho bboyho closed this Feb 6, 2019
@bboyho bboyho self-assigned this Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants