Skip to content
This repository was archived by the owner on Jun 15, 2023. It is now read-only.

Mark items#44

Merged
cryogenian merged 2 commits intoslamdata:masterfrom
cryogenian:mark-items
Aug 21, 2017
Merged

Mark items#44
cryogenian merged 2 commits intoslamdata:masterfrom
cryogenian:mark-items

Conversation

@cryogenian
Copy link
Copy Markdown
Member

Sorry, I misunderstood echarts API, data need to be wrapped to array once more.

Also added markLine example @SayLU

echarts version is freezed before ecomfe fixes candlestick behaviour.

@cryogenian cryogenian merged commit 3a63c19 into slamdata:master Aug 21, 2017
@thomashoneyman
Copy link
Copy Markdown

Awesome, thanks @cryogenian. I've been able to replicate the example.

In my use case, I simply need a line across the entire axis. In ECharts, I'd provide a property like xAxis: 20.0. Here's a minimal example:

https://codepen.io/saylu/pen/Zyyzgq

I tried a variant like this:

        E.markLine do
          E.lineStyle $ E.normal do
            E.solidLine
          E.buildMarkItems do
            E.addItem do
              E.symbol ET.None
              E.y 100.0

However, it seems (by looking at the generated JS) that this always expects coordinates. Is that the case?

Cheers,
Thomas

@cryogenian
Copy link
Copy Markdown
Member Author

Exactly

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants